Skip to content

feat(desktop): share the Local Runtime Host - #3971

Closed
M4n5ter wants to merge 1 commit into
apache:feat/runtime-host-direct-peer-desktopfrom
M4n5ter:feat/desktop-local-host-remote-access
Closed

feat(desktop): share the Local Runtime Host#3971
M4n5ter wants to merge 1 commit into
apache:feat/runtime-host-direct-peer-desktopfrom
M4n5ter:feat/desktop-local-host-remote-access

Conversation

@M4n5ter

@M4n5ter M4n5ter commented Aug 27, 2026

Copy link
Copy Markdown
Member
English

Summary

Let a user expose the current computer's Local Runtime Host to another Maka Desktop without creating a second Host or copying its State Root

  • hands the existing Local Host from the ephemeral Desktop child to the OS-managed service
  • keeps Local IPC and experimental Direct peer active on the same Host
  • adds versioned, one-time Owner connection codes and an atomic import flow
  • keeps disabling connectivity separate from uninstalling the service or revoking credentials

This PR is stacked on #3950

Refs #3842

Verification

  • npm run typecheck
  • npm run lint -- --diagnostic-level=error
  • npm run format:check
  • npm run build
  • npm run check:stale
  • npm run check:asf-headers
  • npm run astryx:surface-inventory
  • affected CLI, Runtime Host, and Desktop test suites
  • real two-Desktop connection-code import over Direct peer, including disable, re-enable, and service uninstall
  • Electron UI checked through CDP with isolated profiles

The full Runtime suite passes standalone; one parallel repository-wide test invocation exited while that suite was running, with no failing test reproduced

UI

Before:

After:

AI use

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: OpenAI Codex assisted with implementation, tests, documentation, and verification under the contributor's direction

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No
中文

摘要

允许用户把当前电脑的 Local Runtime Host 提供给另一台 Maka Desktop 使用,同时不创建第二个 Host,也不复制 State Root

  • 将现有 Local Host 从 Desktop 临时子进程交接给操作系统托管服务
  • 同一个 Host 同时保留 Local IPC 与实验性的 Direct peer listener
  • 增加版本化、一次性的 Owner 连接码和原子导入流程
  • 明确区分关闭连接方式、卸载服务与撤销凭据

本 PR 堆叠在 #3950 之上

关联 #3842

验证

  • npm run typecheck
  • npm run lint -- --diagnostic-level=error
  • npm run format:check
  • npm run build
  • npm run check:stale
  • npm run check:asf-headers
  • npm run astryx:surface-inventory
  • 受影响的 CLI、Runtime Host 与 Desktop 测试套件
  • 使用两个真实 Desktop 通过 Direct peer 导入连接码,并验证关闭、重新开启和卸载服务
  • 使用隔离 profile 通过 CDP 检查 Electron UI

Runtime 完整测试单独运行通过;一次仓库级并行测试在该套件运行期间退出,未能复现具体失败测试

界面

修改前:

修改后:

AI 使用

  • 没有生成式工具作出实质贡献
  • 生成式工具作出了实质贡献

工具与范围:OpenAI Codex 在贡献者指导下协助实现、测试、文档与验证

检查清单

  • 测试覆盖本次变更,并会在缺少变更时失败
  • lint、format、typecheck 与受影响测试套件均已在本地通过

本 PR 是否改变行为?

  • 是——已在摘要中说明

@M4n5ter
M4n5ter force-pushed the feat/runtime-host-direct-peer-desktop branch from 0c5833e to cef7258 Compare August 27, 2026 05:15
Move the Local Host to its existing managed-service lifecycle when remote access is enabled, while retaining Local IPC and the same State Root. Add one-time Direct peer connection codes and Desktop import/export UX without creating a second Host identity.

Generated-by: OpenAI Codex
@M4n5ter
M4n5ter force-pushed the feat/desktop-local-host-remote-access branch from 463e1a8 to 1aace98 Compare August 27, 2026 05:17
@M4n5ter
M4n5ter deleted the branch apache:feat/runtime-host-direct-peer-desktop August 27, 2026 05:45
@M4n5ter M4n5ter closed this Aug 27, 2026
@M4n5ter

M4n5ter commented Aug 27, 2026

Copy link
Copy Markdown
Member Author
English

#3950 was merged and its base branch was deleted, which automatically closed this stacked PR. After rebasing the head onto the merged main, GitHub would not reopen the PR because the head had necessarily been force-pushed. The unchanged continuation is #3972.

简体中文

#3950 合并并删除 base 分支后,GitHub 自动关闭了这个 stacked PR。head 重放到已合并的 main 后,由于必需的 force-push,GitHub 不再允许重新打开该 PR。后续审查入口为 #3972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant